Draft PR: Create Scope Visualizer for "that" Mark#3141
Closed
trillium wants to merge 4 commits intocursorless-dev:mainfrom
Closed
Draft PR: Create Scope Visualizer for "that" Mark#3141trillium wants to merge 4 commits intocursorless-dev:mainfrom
trillium wants to merge 4 commits intocursorless-dev:mainfrom
Conversation
Member
|
I understand the use case, but I think this implementation is problematic. You're actually turning the that mark into a proper scope which introduces an ambiguity in the grammar. eg |
Contributor
Author
|
Roger, will try again with something that doesn't hook into the scope visualizer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure this is the intended use of the scope visualizer, but I wanted to see what it would be like to have the
thatmark highlighted persistently.Haven't really played with this outside of the debug VSCode window, but it works!
Screenshot